various updates (#23) #59

vveliev-tc · 2019-07-10T19:26:06Z

Set description to cmd args of parallel_tests process
Fix matcher to detect when start time needs to be updated
Clean up formatting in report.rb
Implement a folder creation lock file to address duplicate folders being created
Delay each process by its ID number to create a staggered start to reporting in Report Portal (addresses load issues)
Formatting and cleanup in parallel_report.rb
Use temporary directory for tracking folder creation
Add commenting around why we are delaying threads
Make sure to use a "full path" for folder creation tracking
fixing report description when run in parallel

refactoring how runner process is detected
- added fallback to cucumber if parallel test was not for parallel formatter

- reverting some changes

launch_uuid related fixes

Fix Cucumber parallel formatter
Fix parallel_tests version and possible endless loop
Add debug logging to debug some issue
Add more debug logging
Remove retrying of requests to Report Portal
Set last_used_time to a time of the parent item
Set description to cmd args of parallel_tests process
Fix URLs to include required "filter.eq.launch" parameter
Fix matcher to detect when start time needs to be updated
Clean up formatting in report.rb
Implement a folder creation lock file to address duplicate folders being created
Delay each process by its ID number to create a staggered start to reporting in Report Portal (addresses load issues)
fixing report description when run in parallel

if launch_id or file_with_launch_id is provided launch will not be marked as finished
moved sleep time, since we are waiting for report to be created anyways

- reverting file lock changes for reading the file

moving lock file related functions to private

- fixing temp file path generation

refactoring how runner process is detected
- added fallback to cucumber if parallel test was not for parallel formatter

using single formatter for both parallel_cucumber and cucumber
adding logger for report portal
updating readme and adding settings for logging level
updating how response processing is handling
fixing issue with child process not closing the folder's items
fixing value for time, removing cucumber IO as it's no longer needed
- adding logging

when run in parallel, child process should not close items in process(folder)

- adding logging

add exception handling when closing item , if already closed , ignore RP 40018 error code

adding patch for multipart
updating version

…ing created

…porting in Report Portal (addresses load issues)

updating parallel run

… folder creation tracking lock file

Continues work and fixes issues with Cucumber parallel executions

…parallel

Feature/cucumber parallel

small refactoring

DzmitryHumianiuk · 2019-07-17T13:57:24Z

@abotalov is it good for merge?
or still require updates?

abotalov · 2019-07-17T14:05:39Z

@DzmitryHumianiuk It still requires updates. Also I've reviewed only some small parts of this PR. I'd prefer if parts I added comments for were addressed before continuing a review.

DzmitryHumianiuk · 2019-07-17T14:07:34Z

@abotalov thank you for comment

DzmitryHumianiuk · 2019-07-25T15:26:35Z

@abotalov your turn

abotalov · 2019-08-08T22:14:29Z

lib/report_portal/cucumber/report.rb

+
+        set_parallel_tests_vars
+
+        if ParallelTests.first_process?


No, it's not fixed.
ParallelTests and Sys::ProcTable are not in Gemfile, they are not required dependencies. A user should be able to use the gem without having to install these dependencies.
If user doesn't specify that they want to run tests in parallel, parallel_tests and sys/proctable should not be required and used.

lib/reportportal.rb

README.md

abotalov · 2019-08-08T22:26:39Z

README.md

@@ -54,6 +60,8 @@ Supported settings:
 - launch_id - id of previously created launch (to be used if formatter_modes contains attach_to_launch)
 - file_with_launch_id - path to file with id of launch (to be used if formatter_modes contains attach_to_launch)
 - disable_ssl_verification - set to true to disable SSL verification on connect to ReportPortal (potential security hole!). Set `disable_ssl_verification` to `true` if you see the following error:
+ - launch_uuid - when formatter_mode is `attach_to_launch`, launch_uuid will be used to create uniq report group(tmp dir should be shared across all lunches)


Put a space before the opening parenthesis - report group (tmp dir should be shared across all lunches)

lunches -> launches

formatter_mode is `attach_to_launch` -> formatter_modes contains `attach_to_launch`

I don't see a difference between launch_id and launch_uuid. launch_id is also a UUID of the launch to be used for attach_to_launch mode. If launch_id is provided by the user, reporting should happen to that launch.

lunch_id is coming from the report portal and forcing you to create lunch beforehand, with luanch_uuid, there is no need to create lunch beforehand. I'm not using the rake and not familiar with it so we have different approaches to solve the same problem.

abotalov · 2019-08-08T22:31:46Z

README.md


-* With Cucumber and parallel_tests gem:
-
-```parallel_cucumber <some options> -o '<some other options> -f ReportPortal::Cucumber::ParallelFormatter'```


It would be good to have an example for parallel_cucumber to show that the gem supports parallel_tests.

I think you're missing the point, it's single formatted for both

I understand that it's a single formatter. But the potential user looking at README should also be aware that agent works when tests are run in parallel.

you are more than welcome to contribute.

abotalov · 2019-08-08T22:39:15Z

README.md

-| attach_to_launch | Do not create a new launch but add executing features/scenarios to an existing launch. Use launch_id or file_with_launch_id settings to configure that. If they are not present client will check rp_launch_id.tmp in `Dir.tmpdir`)
-| use_same_thread_for_reporting | Send reporting commands in the same main thread used for running tests. This mode is useful for debugging this Report Portal client. It changes default behavior to send commands in the separate thread. Default behavior is there not to slow test execution. |
-| skip_reporting_hierarchy | Do not create items for folders and feature files |
+<table><thead><tr><th>Name</th><th>Purpose</th></tr></thead>


This is rendered with horizontal scrolling in Github. So a text becomes harder to read in comparison to the current table rendered using Github flavored markdown.

I don't see any scroling

https://github.github.com/gfm/#html-blocks - not sure what you are asking.

As you can see on the screenshot you attached, not all text in column "Purpose" is visible. There is a horizontal scrolling (at least in Chrome).
https://github.com/reportportal/agent-ruby/blob/7be5353c31be361a2a73b93b83f8e4dffacd8c1b/README.md

sure, but I don't see what is the issue here. If you know how to do multiple lines in a simple table block let me know.

Previous formatting looked better in the browser IMO. Could you use it?

That is subjective. Put everything in a single paragraph, and it will not look good in the browser IMO. Hense I had to change it to be more presentable.

abotalov · 2019-08-08T22:44:06Z

lib/report_portal/cucumber/formatter.rb

@@ -7,12 +7,10 @@ module Cucumber
    class Formatter
      # @api private
      def initialize(config)
-        ENV['REPORT_PORTAL_USED'] = 'true'
-
+        @logger = Logger.new(config.out_stream)


Logger is not loaded by Ruby itself. So there should be a require statement before it's first used.

agent-ruby/lib/report_portal/logging/logger.rb

Line 1 in 7be5353

require 'logger'

agent-ruby/lib/report_portal/cucumber/report.rb

Line 9 in 7be5353

require_relative '../logging/logger'

* Fix sending plain text to attachment * fixing layout errors Fix sending plain text to attachment removing trailing whitespace * adding gemspec dependency * updating readme * fixing gemspec, code formatting * fixing typo, gemspec update * fixing issue with formatter when file with launch id is provided * fixing typos * fixing typos * fixing typos

Develop

vveliev-tc · 2019-08-12T19:58:41Z

It's been a while since PR was open, I have been moved to the different project so if you guys want to merge these changes. PR to my branch is welcome to ensure that it works in our different use cases of the same library. It's been working fine for us so far.

All the checks are passing so I don't see any issues. If you guys want to be picky to the cosmetics of the readme or whatnot, then you can commit changes to make it what you desire. I have no problem using the fork of this project but wanted to contribute back as I like the idea of the report portal. And If you have time for #60(which solves nothing from my opinion), there should not have been a problem finishing this PR as well in a timely fashion.

…iday Feature/cucumber parrallel fariday

splitting client to stand alone class, need to add error handling

Develop

vveliev-tc · 2019-08-16T15:53:54Z

fixed issues that were introduced after rebasing, using persistent connection now

DzmitryHumianiuk · 2019-12-01T17:55:06Z

@abotalov are we good to go here?

abotalov · 2019-12-02T12:00:51Z

The scope of this PR is too large. It makes a number of changes in public API, fixes some bugs, adds some features, does a lot of refactoring. So it's hard to review. I'd prefer to just close it.
I'm fine to do sensible changes in PRs with limited scope.

Andrei Botalov and others added 30 commits January 25, 2018 19:28

Fix Cucumber parallel formatter

ec9b1b1

Fix parallel_tests version and possible endless loop

a41828b

Unify common code in Cucumber Formatter and ParallelFormatter

97e1f5d

Add debug logging to debug some issue

69da60c

Set report_on_exception = true for Report Portal thread on Ruby 2.4+

75ad0f9

Add more debug logging

3def39e

Remove retrying of requests to Report Portal

25c5159

Set last_used_time to a time of the parent item

f18bb5e

Remove log debug statements

396a961

Set description to cmd args of parallel_tests process

e1c4805

Pin parallel_tests Gem to 2.15.0 and sys-proctable Gem to 1.1.5

623fd05

Fix URLs to include required "filter.eq.launch" parameter

80c4380

Fix matcher to detect when start time needs to be updated

1153181

Clean up formatting in report.rb

05b83ba

Implement a folder creation lock file to address duplicate folders be…

62b388d

…ing created

Delay each process by its ID number to create a staggered start to re…

4ea36e6

…porting in Report Portal (addresses load issues)

Formatting and cleanup in parallel_report.rb

3c58d20

Merge branch 'fix_parallel_cucumber_formatter'

e11290b

Use temporary directory for tracking folder creation

580850b

Add commenting around why we are delaying threads

b188a34

Make sure to use a "full path" for folder creation tracking

10fb831

Merge pull request #1 from mikesalvia/master

2c26a48

updating parallel run

Switch to use class instance variables instead of global variable for…

357e707

… folder creation tracking lock file

Merge pull request reportportal#33 from mikesalvia/master

868f789

Continues work and fixes issues with Cucumber parallel executions

work in progress, refactoring lock generation for parallel tests

c540c01

fixing parallel execution

7ed6e2c

Merge branch 'fix_parallel_cucumber_formatter' into feature/cucumber_…

c49d5eb

…parallel

Merge pull request #2 from vveliev-tc/feature/cucumber_parallel

a69014c

Feature/cucumber parallel

small refactoring

c01819c

Merge pull request #3 from vveliev-tc/feature/cucumber_parallel

86bc1c7

small refactoring

DzmitryHumianiuk requested a review from abotalov July 17, 2019 13:56

fixing issue with formatter when file with launch id is provided

7be5353

abotalov requested changes Aug 8, 2019

View reviewed changes

vveliev-tc and others added 6 commits August 8, 2019 21:15

fixing typos

92af68d

fixing typos

72d496a

fixing typos

efc07c0

Merge branch 'master' into develop

00e5d88

Merge pull request #25 from vveliev-tc/develop

da82da3

Develop

vveliev-tc and others added 8 commits August 15, 2019 22:40

Merge branch 'master' into feature/cucumber_parrallel_fariday

cd14bd3

Merge pull request #26 from vveliev-tc/feature/cucumber_parrallel_far…

0811ede

…iday Feature/cucumber parrallel fariday

splitting client to stand alone class, need to add error handling

ead9cc1

fixing patch typo, making sure attachments work

8414edc

Merge branch 'develop' into feture/cleanup

3c76071

Merge pull request #27 from vveliev-tc/feture/cleanup

69ed4ae

splitting client to stand alone class, need to add error handling

Merge pull request #28 from vveliev-tc/develop

c7c177b

Develop

rubocop fix

2de8740

vveliev-tc mentioned this pull request Aug 16, 2019

Replace RestClient gem with HTTP #60

Merged

Merge branch 'master' into feature/cucumber_parrallel_fariday

e400952

abotalov closed this Dec 2, 2019

vveliev-tc deleted the feature/cucumber_parrallel_fariday branch December 2, 2019 20:45

vveliev-tc mentioned this pull request Mar 31, 2020

Make API to follow rest-full style for attachments. reportportal/reportportal#891

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

various updates (#23) #59

various updates (#23) #59

vveliev-tc commented Jul 10, 2019

DzmitryHumianiuk commented Jul 17, 2019

abotalov commented Jul 17, 2019 •

edited

Loading

DzmitryHumianiuk commented Jul 17, 2019

DzmitryHumianiuk commented Jul 25, 2019

abotalov Aug 8, 2019

abotalov Aug 8, 2019

vveliev-tc Aug 9, 2019

abotalov Aug 8, 2019

vveliev-tc Aug 9, 2019

abotalov Aug 9, 2019 •

edited

Loading

vveliev-tc Aug 9, 2019

abotalov Aug 8, 2019

vveliev-tc Aug 9, 2019

vveliev-tc Aug 9, 2019

abotalov Aug 9, 2019

vveliev-tc Aug 9, 2019

abotalov Aug 9, 2019 •

edited

Loading

vveliev-tc Aug 9, 2019

abotalov Aug 8, 2019

vveliev-tc Aug 9, 2019

vveliev-tc Aug 9, 2019

vveliev-tc commented Aug 12, 2019

vveliev-tc commented Aug 16, 2019

DzmitryHumianiuk commented Dec 1, 2019

abotalov commented Dec 2, 2019 •

edited

Loading


		* With Cucumber and parallel_tests gem:

		```parallel_cucumber <some options> -o '<some other options> -f ReportPortal::Cucumber::ParallelFormatter'```

various updates (#23) #59

various updates (#23) #59

Conversation

vveliev-tc commented Jul 10, 2019

DzmitryHumianiuk commented Jul 17, 2019

abotalov commented Jul 17, 2019 • edited Loading

DzmitryHumianiuk commented Jul 17, 2019

DzmitryHumianiuk commented Jul 25, 2019

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

abotalov Aug 9, 2019 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

abotalov Aug 9, 2019 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

vveliev-tc commented Aug 12, 2019

vveliev-tc commented Aug 16, 2019

DzmitryHumianiuk commented Dec 1, 2019

abotalov commented Dec 2, 2019 • edited Loading

abotalov commented Jul 17, 2019 •

edited

Loading

abotalov Aug 9, 2019 •

edited

Loading

abotalov Aug 9, 2019 •

edited

Loading

abotalov commented Dec 2, 2019 •

edited

Loading